Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablesorter -- master // ipv4 and network parser #1344

Closed
thezoggy opened this issue Dec 29, 2016 · 2 comments
Closed

tablesorter -- master // ipv4 and network parser #1344

thezoggy opened this issue Dec 29, 2016 · 2 comments

Comments

@thezoggy
Copy link
Collaborator

ipv4 parser doesnt look like it works anymore until you use the network parser...

https://mottie.github.io/tablesorter/docs/example-parsers-ip-address.html
<li>The default "ipAdress" parser (IPv4) is included with the original tablesorter; it was moved to the <code>parser-network.js</code> file in <span class="version">v2.18.0</span>.</li>

was that supposed to say 'is NO LONGER included'?

loading the network parser I see:

TypeError: ts is undefined
file:///F:/test/js/parsers/parser-network.js
Line 17
@Mottie
Copy link
Owner

Mottie commented Dec 29, 2016

Hi @thezoggy!

Yes, I moved the ipAddress parser into a separate file and replaced it with an image parser since it is much more common. I should make that change more obvious... or add it back?

The network parser should be loaded after tablesorter. I think that is why you're seeing that error. ts is defined on line 7: var ts = $.tablesorter.

@thezoggy
Copy link
Collaborator Author

yep thats what it was. yeah once i loaded the parser js then the ipv4 parser works. the docs just made it sound like i only needed the parser for v6..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants