Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full CSS, please ! #1222

Closed
mcd-php opened this issue May 30, 2016 · 5 comments
Closed

Full CSS, please ! #1222

mcd-php opened this issue May 30, 2016 · 5 comments

Comments

@mcd-php
Copy link

mcd-php commented May 30, 2016

In my web projects, I use ASSET_INFIX variable to load minified CSS and JS in production and full in debug.

Some lonely 404 flew by among many successful dependencies, it was this project.

So I had to kludge my asset pipeline for exception.

@Mottie
Copy link
Owner

Mottie commented May 30, 2016

Hi @mcd-php!

Sorry, are you asking to include the non-minified css along with the minified in the dist folder? If you're loading the entire repository, then you can point your scripts to ./css folder.

@TheSin-
Copy link
Collaborator

TheSin- commented May 30, 2016

I'm just guessing here, but I assume that since he uses a class to do all the loading, that it expects both the min and full version in the same folder. That being said The current way isn't that abnormal and he might just need to make a symlink from the css to the dist folder which won't break git updates. Either way I'm not sure it's an issue for here, if anything maybe a request.

@mcd-php
Copy link
Author

mcd-php commented May 30, 2016

No, I load from cdnjs, and removing .min gives 404.

So I believe the issue should be resolved by guidelines of https://github.com/cdnjs/cdnjs and probably some other major providers like this. Probably this requires min/max files alongside, like in https://cdnjs.com/libraries/jqueryui

@TheSin-
Copy link
Collaborator

TheSin- commented May 30, 2016

ahh there is the info we needed, you on this @Mottie I don't thin kI have access to cndjs to help, I've never used it before.

@Mottie
Copy link
Owner

Mottie commented May 30, 2016

Ahh, ok... I just need to include the css & probably the js folders in these package.json sections

  "npmName": "tablesorter",
  "npmFileMap": [
    {
      "basePath": "",
      "files": [
        "dist/**/*",
        "css/*",
        "js/**/*"
      ]
    }
  ],
  "autoupdate": {
    "source": "git",
    "target": "git://github.com/Mottie/tablesorter.git",
    "basePath": "",
    "files": [
      "dist/**/*",
      "css/*",
      "js/**/*"
    ]
  },

One of those sections updates CDNJS automatically, but won't happen until a new release is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants