Ticker check #8
Ticker check #8
Conversation
|
Hi @arkanoider ! Thanks, I see you uppercased the currency, the currency list can be useful, if the user use one currency we know, we can use some stuff related from that list like the emoji for example, but as i commented here #2 (comment) we shouldn't limit users to use our fiat currency list because users could use any other currency they like, it can be a regional currency which we don't know it exists or even a shitcoin. This should try to find if there is orders for the currency with code |
|
Hi @grunch got it, we can avoid the error message if it's not on the list and only check against the result from the relays. We can avoid using the list at all at this point except for some cosmetics. Will work on it! |
…e only if there is a match with selected curency
|
Hi @grunch did ticker check more "free" users now can select any currency ticker and it will be upcased and checked against relay result. In case of no match with result an error table like this is printed out. I think it's more like what you were thinkin about. We can use anyway later the parse of "famous" currencies to do some cosmetics. Table error like: |
src/main.rs
Outdated
| @@ -33,6 +37,24 @@ async fn main() -> Result<()> { | |||
| }) => { | |||
| let mostro_key = XOnlyPublicKey::from_bech32(pubkey)?; | |||
|
|
|||
| //Commented for later use maybe... | |||
There was a problem hiding this comment.
let's remove the code we are not using
src/util.rs
Outdated
| //Table rows | ||
| let mut rows: Vec<Row> = Vec::new(); | ||
|
|
||
| if orderstable.is_empty(){ |
|
Hi @grunch should have fixed all Rust basic rules. Let me know. Check this : Moved after check on verbose flag to correctly initialize env var in the case it's activated. |
|
Looks great, thanks @arkanoider |
|
Amazing! Let's continue on #3 |
While starting to work on #3 I tried to implement ticker check, now:
Maybe it's not the best rust implementation, but is working. Another small update could be a command like:
mostro-cli list-currencies
to get a print on std output of all the tickers...also if it's a bit long.
Let me know!!