Order preview draft #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunch
requested changes
Mar 10, 2023
There was a problem hiding this comment.
It looks good, can we allow to the user respond only with y or n ? and a default value, i.e.:
order preview
Check your order! Is it correct? [Y/n]
If the user hits enter the default value y will be assigned, other wise the user should enter y or n, it should work with case insensitive Y=y and N=n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @grunch finally i found some time to move on.
Give a look at this draft idea or order preview, lot to do to have more clean code, but it's working.
You can create the order and check the preview, I have to test a lot of things, but the basics are workin.
I forced to wait connection to relays to avoid info messages before order, but surely a cleaner solution is possible.
Let me know!