Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neworder cmd first usable version #16

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Conversation

arkanoider
Copy link
Collaborator

Hi @grunch ! Here the first neworder cmd usable version.

I have been able to add orders like a charm.
Things to do:

  • Add the min, max logic to sats number.
  • Check if we always exit from the waiting OK loop, one time seemed to get stuck.

@grunch grunch marked this pull request as ready for review March 4, 2023 15:07
@grunch
Copy link
Member

grunch commented Mar 4, 2023

great job buddy! let's approve this to start playing with it now, we'll improve it later

@grunch grunch merged commit 89f5747 into MostroP2P:main Mar 4, 2023
@arkanoider arkanoider deleted the neworder_cmd branch March 4, 2023 19:33
@grunch grunch mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants