-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct message #11
Direct message #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, there are some things to change before merge this PR, and also please before push run cargo fmt
and cargo clippy
Yes @grunch ! Will do asap! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @arkanoider thanks for this PR, still the build if failing, can you check on All checks have failed
details link?
Hi @grunch i committed something yesterday, just to don't lose work. I know it's not compiling, workin on it. I think that github automatically send you a notification if I commit on the same branch. |
Yes github sent me the notification, you can change this PR to draft until is ready for review 😃 |
Hi @grunch give a look... Let me know! |
Cosmetics for clap help on subcommands flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow this is something!! LGTM!!! thanks buddy
Thanks @grunch it's an honor for me...and it's my small contribution to bitcoin and satoshi. |
take a look on the issues I created 😀 |
Hi @grunch !
Finally did some work on get direct message command, code is full of duplication and needs to be refined.
Surely as you pointed out we need to spawn requests to relays to avoid long time execution.
Table answer for direct message need to have also time inside, will provide it! Also i put a totally static "since time" of an hour. So you cannot see previous message, maybe using a flag for a since time could be useful?
Anyway at least is working now.