Skip to content

Commit

Permalink
Make difference module handle circular cubes (metoppv#2016)
Browse files Browse the repository at this point in the history
* Resolved merge conflict

* Added another failing test for difference module. Differences calculated correctly but need to add extra dimension for the wrap-around distance.

* Resolved merge conflicts

* Auto-formatting

* Import Bugfix

* Ran isort against spatial.py

* Added test for appropriate error for unhandled cubes and made code match it.

* iSort on spatial.py again

* Another attempt at autoformatting

* Tidied up

* Removed confusing variable name

* Autoformatting

* Tried manually sorting import order as isort still failing in github actions despite running locally and pushing

* And again

* And again

* Linting suggestion

* Review Actions

* Ran isort to fix gha

* Added test for cubes with flipped axes (lonitude increasing along columns not rows and vice versa for latitude). Fixed code to handle this case.

* black, isort, flake8

* Ran isort in isolation

* Fixed test failures resulting from breaking changes made by upstream PR

* Black

* updates as per review comments and adds test for 0-360 degree case

* update comment

* formatting

---------

Co-authored-by: Marcus Spelman <[email protected]>
  • Loading branch information
2 people authored and MoseleyS committed Aug 23, 2024
1 parent 53e09a1 commit 8c0d93b
Show file tree
Hide file tree
Showing 2 changed files with 94 additions and 392 deletions.
Loading

0 comments on commit 8c0d93b

Please sign in to comment.