Fix issue where large GradientFill / GradientStroke would be cut …

…off (airbnb#1721)
MoroziOS · May 22, 2024 · f4b4b9d · f4b4b9d
1 parent 818ebb0
commit f4b4b9d
Show file tree

Hide file tree

Showing 42 changed files with 4 additions and 2 deletions.
diff --git a/Sources/Private/CoreAnimation/Layers/GradientRenderLayer.swift b/Sources/Private/CoreAnimation/Layers/GradientRenderLayer.swift
@@ -59,7 +59,7 @@ final class GradientRenderLayer: CAGradientLayer {
   ///  - This specific value is arbitrary and can be increased if necessary.
   ///    Theoretically this should be "infinite", to match the behavior of
   ///    `CGContext.drawLinearGradient` with `[.drawsAfterEndLocation, .drawsBeforeStartLocation]`.
-  private let gradientPadding: CGFloat = 2_000
+  private let gradientPadding: CGFloat = 10_000
 
   private func updateLayout() {
     anchorPoint = .zero

diff --git a/Tests/PerformanceTests.swift b/Tests/PerformanceTests.swift
@@ -50,7 +50,7 @@ final class PerformanceTests: XCTestCase {
 
     // The automatic engine option should have the same performance as the core animation engine,
     // when rendering an animation supported by the CA engine.
-    XCTAssertEqual(ratio, 1.0, accuracy: 0.4)
+    XCTAssertEqual(ratio, 1.0, accuracy: 0.5)
   }
 
   func testAnimationViewScrubbing_simpleAnimation() {

diff --git a/Tests/Samples/Issues/issue_1717.json b/Tests/Samples/Issues/issue_1717.json
diff --git a/Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-issue_1717.txt b/Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-issue_1717.txt
@@ -0,0 +1 @@
+Supports Core Animation engine
diff --git a/...pshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-0.png b/...pshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-0.png
diff --git a/...hots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-100.png b/...hots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-100.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-25.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-25.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-50.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-50.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-75.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1407-75.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1636-25.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1636-25.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1636-50.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1636-50.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1636-75.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1636-75.png
diff --git a/...pshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-0.png b/...pshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-0.png
diff --git a/...hots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-100.png b/...hots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-100.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-25.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-25.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-50.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-50.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-75.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_1717-75.png
diff --git a/...s__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-0.png b/...s__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-0.png
diff --git a/..._/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-100.png b/..._/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-100.png
diff --git a/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-25.png b/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-25.png
diff --git a/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-50.png b/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-50.png
diff --git a/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-75.png b/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_1-75.png
diff --git a/...s__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-0.png b/...s__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-0.png
diff --git a/..._/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-100.png b/..._/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-100.png
diff --git a/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-25.png b/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-25.png
diff --git a/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-50.png b/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-50.png
diff --git a/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-75.png b/...__/SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_2-75.png
diff --git a/.../SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-0.png b/.../SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-0.png
diff --git a/...napshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-100.png b/...napshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-100.png
diff --git a/...SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-25.png b/...SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-25.png
diff --git a/...SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-50.png b/...SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-50.png
diff --git a/...SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-75.png b/...SnapshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_pill-75.png
diff --git a/...napshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-0.png b/...napshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-0.png
diff --git a/...pshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-100.png b/...pshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-100.png
diff --git a/...apshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-25.png b/...apshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-25.png
diff --git a/...apshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-50.png b/...apshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-50.png
diff --git a/...apshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-75.png b/...apshotTests/testCoreAnimationRenderingEngine.LottieFiles-gradient_shapes-75.png
diff --git a/...Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-0.png b/...Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-0.png
diff --git a/...apshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-100.png b/...apshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-100.png
diff --git a/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-25.png b/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-25.png
diff --git a/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-50.png b/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-50.png
diff --git a/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-75.png b/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_1717-75.png