refactor: pay_outstanding_debt extrinsic of pallet-payment-streams
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffarall
approved these changes
Nov 21, 2024
snowmead
approved these changes
Nov 21, 2024
| pub fn pay_outstanding_debt( | ||
| origin: OriginFor<T>, | ||
| amount_of_streams_to_pay: u32, | ||
| providers: Vec<ProviderIdFor<T>>, |
There was a problem hiding this comment.
It's bounded by the weight of the extrinsic! Basically the caller of this will pay for its execution proportional to the amount of Providers, so it shouldn't be an issue. I thought about making it a bounded vec and bounding it with a constant of the Config of the pallet, maybe that's better? @ffarall cc'ing you just in case
There was a problem hiding this comment.
Worst case scenario, the user sends a transaction that can take up A LOT of weight, but we know that in advance and will charge him for it. Whether or not this could result in another issue... unclear to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
get_providers_with_payment_streams_with_user, which receives a user and returns the list of Providers that have at least one payment stream with it. This is useful for users that were deemed insolvent and want to recoup as much of their paid deposits as possible calling thepay_outstanding_debtextrinsic of the payment streams pallet.pay_outstanding_debtextrinsic to, instead of receiving the number of payment streams to pay, it receives a list of Providers. This way, it checks if that Provider has payment streams with the user and pays it the remaining debt, without having unbounded iterations. Weight is then proportional to the amount of Providers that the user wants to repay.