Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 🧪 New re-org tests and helpers #263

Merged
merged 12 commits into from
Nov 26, 2024
Merged

test: 🧪 New re-org tests and helpers #263

merged 12 commits into from
Nov 26, 2024

Conversation

timbrinded
Copy link
Collaborator

@timbrinded timbrinded commented Nov 19, 2024 •
edited
Loading

Changes:

  • Adds new extendFork() to the block api, to allow the system
    • NB this current causes a wasm panic on forks longer than 3 blocks
  • CI sharding changes to improve execution times
  • New disabled tests prior to the reorg functionality that is soon to be added

@timbrinded timbrinded marked this pull request as ready for review November 19, 2024 16:57
@timbrinded timbrinded requested a review from a team November 19, 2024 16:57
ffarall
ffarall requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ffarall ffarall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes but mostly to have a quick chat and clarify what the testing case that we wanted to test was about.

test/suites/integration/bsp/submit-proofs.test.ts Outdated Show resolved Hide resolved
test/suites/integration/bsp/submit-proofs.test.ts Outdated Show resolved Hide resolved
@timbrinded
Copy link
Collaborator Author

Looks live my refactor has broken something, so need to do a fix next week- but in the meantime have a look at the new test cases ive written. Three failing test cases which should be useful for your feature branch next week @ffarall

ffarall
ffarall approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ffarall ffarall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just som eminor comments, but great work!

test/util/bspNet/block.ts Show resolved Hide resolved
test/util/bspNet/block.ts Outdated Show resolved Hide resolved
@ffarall
Copy link
Contributor

ffarall commented Nov 25, 2024

Also, please change the title and description of the PR, they don't really fit now.

@timbrinded timbrinded changed the title test: 🧪 Adds proofsubmit finalise test test: 🧪 New re-org tests and helpers Nov 26, 2024
@timbrinded timbrinded merged commit 64aa4c1 into main Nov 26, 2024
24 checks passed
@timbrinded timbrinded deleted the test/finality-proof-submit branch November 26, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffarall ffarall ffarall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timbrinded @ffarall