test: added BSP delete file test #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undercover-cactus
force-pushed
the
test/delete-proof
branch
from
5943141
to
8069a5a
Compare
| method: "submitProof", | ||
| checkTxPool: true, | ||
| timeout: 100 | ||
| }); |
There was a problem hiding this comment.
This is working but not what we discussed. The assertExtrinsicPresent function doesn't return the actual extrinsic so I cannot check the bspId (also not the actual ID but the adddress).
I could add an optional address value to assertExtrinsicPresent to verify it is indeed the one that submitted the proof but it would be pretty specific to submitProof method.
For now this is working just to check when we have one BSP trying to store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR test the process for a BSP to request to stop storing a file. The previously needed
generateForestProoffunction was missing but is now available.