Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: msp chargeable tick is current tick #234

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

undercover-cactus
Copy link
Contributor

Last chargeable tick is set by default to be the current tick.

In case of dynamic payment we get the last chargeable info and get the last chargeable tick for it.

pallets/payment-streams/src/lib.rs Outdated Show resolved Hide resolved
pallets/payment-streams/src/lib.rs Outdated Show resolved Hide resolved
pallets/payment-streams/src/utils.rs Outdated Show resolved Hide resolved
pallets/payment-streams/src/utils.rs Outdated Show resolved Hide resolved
pallets/payment-streams/src/utils.rs Outdated Show resolved Hide resolved
pallets/payment-streams/src/utils.rs Outdated Show resolved Hide resolved
pallets/payment-streams/src/utils.rs Outdated Show resolved Hide resolved
pallets/payment-streams/src/utils.rs Outdated Show resolved Hide resolved
pallets/payment-streams/src/tests.rs Show resolved Hide resolved
Copy link
Contributor

@snowmead snowmead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo @ffarall comment about the tests

@undercover-cactus
Copy link
Contributor Author

I have now a failing test charge_three_users_with_different_payment_streams_works. This test is failing because when Alice sign up as a MSP they are registered as Privilege Provider now.

So when a dynamic stream payment is being charged the index price returned is the default value which is 0 and not the value from the ProviderLastChargeableInfo that has been inserted in the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants