Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ Add stop time functionality to Proofs Dealer pallet #195

Merged
merged 50 commits into from
Sep 28, 2024
Merged

feat: ✨ Add stop time functionality to Proofs Dealer pallet #195

merged 50 commits into from
Sep 28, 2024

Conversation

ffarall
Copy link
Contributor

@ffarall ffarall commented Sep 16, 2024

No description provided.

@ffarall
refactor: ♻️ Rename ChallengeTickToChallengedProviders -> `TickToPr…
c114af0 
…ovidersDeadlines`
@ffarall
feat: ✨ ChallengesTicker can now be paused
14c809c
@ffarall
feat: 🚧 Implement on_finalize hook to register block weight used
b9fd527
@ffarall
feat: 🚧 Implement spamming condition check
afd4b2b
@ffarall
feat: 🚧 Update runtime configs with new parameters
4042f3a
@ffarall
fix: 🐛 Use mutate correctly and only run spam check after tick supr…
c5a7ba2 
…asses block fullness period
@ffarall
fix: 🚨 Update types to new storage element name
4053deb
@ffarall
test: 🚧 Write pending tests
dfd683c
@ffarall
fix: 🐛 Check for spamming after incrementing tic
1a08808
@ffarall
test: ✅ Add passing tests of network spammed
bd6ac11
@ffarall
fix: 🐛 Consider block not full when weight left is exactly headroom
cb4f7a9
@ffarall
test: Add tests for how much weight is considered block full
714ec8d
@ffarall
test: ✅ Add test cases for exact number of spammed blocks tolerated
a6bd8bd
@ffarall
test: ✅ Add test for ticker not affected in MBM
9dd52df
@ffarall
test: ✅ Provider is not marked as slashable when network is spammed
48efb02
@ffarall
feat: ✨ Add get_current_tick() function to ProofsDealerInterface
2099a6a
@ffarall
feat: ✨ Make threshold calculations depend on ticks instead of block …
f9a625e 
…numbers to prevent spam attack
@ffarall
chore: 🏷️ Update types-bundle runtime API with ticks instead of blocks
93b9399
@ffarall
feat: ✨ Update blockchain service and BSP tasks to use ticks instead …
5fc4cad 
…of blocks for volunteering
@ffarall
test: 🧑‍💻 Hide consolo logs behind verbose flag in integration test…
b36ce88 
…s for better readability
@ffarall
Merge branch 'main' into feat/add-stop-time-functionality
4f5e367
@ffarall
fix: 🚨 Fix dangling compile error from merge
ef0413f
@ffarall
chore: 🏷️ Update api-augment
356ffe8
@ffarall
test: 🐛 Fix integration tests to use new variables and constant names…
8cf68f0 
… with "tick"
@ffarall
test: ✅ Add spamming tests for file system pallet
6d3713f
@ffarall
fix: 🩹 Use less complicated types in file system tests to improve rus…
b611aa5 
…t analyzer usability
@ffarall
test: ✅ Add threshold test with stopping time due to spamming attack
ba21d24
@ffarall
revert: ⏪ Rollback only and networkConfig flags in threshold testing
fef5666
@ffarall
refactor: ♻️ Reorder tests to keep them as they were then adding new …
345b023 
…test at the end
@ffarall ffarall marked this pull request as ready for review September 20, 2024 02:44
@ffarall ffarall requested review from snowmead, TDemeco and timbrinded and removed request for snowmead September 20, 2024 02:44
snowmead
snowmead approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@snowmead snowmead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beast!

pallets/proofs-dealer/src/lib.rs Outdated Show resolved Hide resolved
pallets/proofs-dealer/src/utils.rs Outdated Show resolved Hide resolved
primitives/traits/src/lib.rs Show resolved Hide resolved
test/util/bspNet/consts.ts Show resolved Hide resolved
test/util/bspNet/consts.ts Show resolved Hide resolved
@ffarall ffarall merged commit e748686 into main Sep 28, 2024
21 checks passed
@ffarall ffarall deleted the feat/add-stop-time-functionality branch September 28, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowmead snowmead snowmead approved these changes

@TDemeco TDemeco Awaiting requested review from TDemeco

@timbrinded timbrinded Awaiting requested review from timbrinded

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffarall @snowmead