Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements, dashboard tests, styling #29

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Improvements, dashboard tests, styling #29

merged 4 commits into from
Oct 21, 2019

Conversation

maricalucian
Copy link
Contributor

Add tests, style changes to support theming, fixes and improvements

@maricalucian maricalucian changed the title Dashboard tests Improvements, dashboard tests, styling Oct 19, 2019
@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #29 into master will increase coverage by 45.72%.
The diff coverage is 98.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #29       +/-   ##
===========================================
+ Coverage   41.55%   87.28%   +45.72%     
===========================================
  Files          26       30        +4     
  Lines         154      173       +19     
  Branches       24       38       +14     
===========================================
+ Hits           64      151       +87     
+ Misses         90       22       -68
Flag Coverage Δ
#unittests 87.28% <98.03%> (+45.72%) ⬆️
Impacted Files Coverage Δ
src/styles/themes/dark-theme.ts 100% <ø> (ø) ⬆️
src/styles/colors.ts 100% <ø> (ø) ⬆️
src/components/account-card/account-card.tsx 100% <ø> (+50%) ⬆️
src/library/text.tsx 88.23% <100%> (+49.77%) ⬆️
src/components/coin-dashboard/styles.ts 100% <100%> (ø)
...components/coin-balance-card/coin-balance-card.tsx 100% <100%> (+83.33%) ⬆️
src/components/convert/convert.tsx 100% <100%> (+62.5%) ⬆️
src/components/conversion-card/conversion-card.tsx 100% <100%> (+50%) ⬆️
src/screens/dashboard/dashboard.tsx 95.23% <100%> (+82.73%) ⬆️
src/components/conversion-card/styles.ts 100% <100%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aea836...63d3fcb. Read the comment docs.

@krisboit krisboit merged commit f276811 into master Oct 21, 2019
@krisboit krisboit deleted the dashboard_tests branch October 21, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants