Art-Net Improvements v2 #179
Conversation
|
GUI demo: WhatsApp.Video.2024-11-07.at.8.42.54.AM.mp4 |
|
@softhack007 Checks all green - your fix was what it needed, thanks! |
|
@troyhacks would it make sense to add proxy mode support fixes from Just if that's not a corner case which makes the code complicated or unstable .... |
That's unrelated to my code. I'm doing Art-Net output here, not input. I guess you could consider it related if I was sending Art-Net data to another WLED board with DMX and expecting it to proxy to wired DMX, but that's an edge case and should be considered separately. (I think that other PR is fine, but @netmindz might have opinions.) |
troyhacks
requested review from
softhack007
and removed request for
netmindz
|
@softhack007 All changes you flagged in the review have been implemented, including the free(). Should be good to merge. |
wled00/data/settings_leds.htm
Outdated
| @@ -314,6 +338,7 @@ | |||
| gId("lc").textContent = sLC; | |||
| gId("pc").textContent = (sLC == sPC) ? "":"(" + sPC + " physical)"; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
additional blank line could be removed
wled00/udp.cpp
Outdated
| static const size_t ART_NET_HEADER_SIZE = 12; | ||
| static const byte ART_NET_HEADER[] PROGMEM = {0x41,0x72,0x74,0x2d,0x4e,0x65,0x74,0x00,0x00,0x50,0x00,0x0e}; | ||
| static const byte ART_NET_HEADER[12] PROGMEM = {0x41,0x72,0x74,0x2d,0x4e,0x65,0x74,0x00,0x00,0x50,0x00,0x0e}; | ||
| static uint_fast16_t framenumber = 0; |
There was a problem hiding this comment.
looks like this is never used?
|
Looks good to me |
|
@troyhacks some problem with the UI - i cannot save the LED settings page
i'll see what can be done ... |
|
Thanks 👍 I'm merging now. |
Fully implemented new Art-Net codebase.
Improvements: