Fix value type out parameters

MoonCollider · Oct 18, 2023 · ebe6b8a · ebe6b8a
1 parent 1710202
commit ebe6b8a
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 5 deletions.
diff --git a/src/Generator/Generators/CSharp/CSharpMarshal.cs b/src/Generator/Generators/CSharp/CSharpMarshal.cs
@@ -634,17 +634,20 @@ public override bool VisitPointerType(PointerType pointer, TypeQualifiers quals)
             {
                 if (Context.Parameter.Usage == ParameterUsage.Out)
                 {
-                    var qualifiedIdentifier = (@class.OriginalClass ?? @class).Visit(typePrinter);
-                    Context.Before.WriteLine("var {0} = new {1}.{2}();",
-                        arg, qualifiedIdentifier, Helpers.InternalStruct);
+                    Context.Before.WriteLine("fixed ({0}.{1}* {2} = &{3}.{4})",
+                        Context.Parameter.QualifiedType, Helpers.InternalStruct,
+                        arg, Context.Parameter.Name, Helpers.InstanceIdentifier);
+                    Context.Before.WriteOpenBraceAndIndent();
+                    Context.Return.Write($"new {typePrinter.IntPtrType}({arg})");
+                    Context.Cleanup.UnindentAndWriteCloseBrace();
                 }
                 else
                 {
                     Context.Before.WriteLine("var {0} = {1}.{2};",
                         arg, Context.Parameter.Name, Helpers.InstanceIdentifier);
+                    Context.Return.Write($"new {typePrinter.IntPtrType}(&{arg})");
                 }
 
-                Context.Return.Write($"new {typePrinter.IntPtrType}(&{arg})");
                 return true;
             }
 

diff --git a/src/Generator/Generators/CSharp/CSharpSources.cs b/src/Generator/Generators/CSharp/CSharpSources.cs
@@ -413,7 +413,7 @@ public override bool VisitClassDecl(Class @class)
                 if (@class.IsValueType)
                 {
                     WriteLine($"private {@class.Name}.{Helpers.InternalStruct} {Helpers.InstanceField};");
-                    WriteLine($"internal {@class.Name}.{Helpers.InternalStruct} {Helpers.InstanceIdentifier} => {Helpers.InstanceField};");
+                    WriteLine($"internal ref {@class.Name}.{Helpers.InternalStruct} {Helpers.InstanceIdentifier} => ref {Helpers.InstanceField};");
                 }
                 else
                 {

diff --git a/tests/dotnet/CSharp/CSharp.Tests.cs b/tests/dotnet/CSharp/CSharp.Tests.cs
@@ -1995,4 +1995,11 @@ public void TestPointerToClass()
         Assert.IsTrue(CSharp.CSharp.PointerToClass.IsDefaultInstance);
         Assert.IsTrue(CSharp.CSharp.PointerToClass.IsValid);
     }
+
+    [Test]
+    public void TestValueTypeOutParameter()
+    {
+	    CSharp.CSharp.ValueTypeOutParameter(out var unionTest);
+	    Assert.AreEqual(2, unionTest.A);
+    }
 }
diff --git a/tests/dotnet/CSharp/CSharp.cpp b/tests/dotnet/CSharp/CSharp.cpp
@@ -1791,3 +1791,8 @@ bool PointerTester::IsValid()
 }
 
 PointerTester* PointerToClass = &internalPointerTesterInstance;
+
+void ValueTypeOutParameter(UnionTester* tester)
+{
+    tester->a = 2;
+}
diff --git a/tests/dotnet/CSharp/CSharp.h b/tests/dotnet/CSharp/CSharp.h
@@ -1603,3 +1603,10 @@ class DLL_API PointerTester
 };
 
 DLL_API extern PointerTester* PointerToClass;
+
+union DLL_API UnionTester {
+    float a;
+    int b;
+};
+
+void DLL_API ValueTypeOutParameter(CS_OUT UnionTester* tester);