Fix cpu leakage (#635)

MontFerret · Jul 16, 2021 · 62a0665 · 62a0665
1 parent 1d0617e
commit 62a0665
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/pkg/drivers/cdp/network/manager.go b/pkg/drivers/cdp/network/manager.go
@@ -44,11 +44,12 @@ type (
 )
 
 func New(
+	ctx context.Context,
 	logger *zerolog.Logger,
 	client *cdp.Client,
 	options Options,
 ) (*Manager, error) {
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(ctx)
 
 	m := new(Manager)
 	m.logger = logger

diff --git a/pkg/drivers/cdp/page.go b/pkg/drivers/cdp/page.go
@@ -58,7 +58,6 @@ func LoadHTMLPage(
 	}
 
 	client := cdp.NewClient(conn)
-
 	if err := enableFeatures(ctx, client, params); err != nil {
 		return nil, err
 	}
@@ -92,8 +91,7 @@ func LoadHTMLPage(
 		netOpts.Filter.Patterns = params.Ignore.Resources
 	}
 
-	netManager, err := net.New(logger, client, netOpts)
-
+	netManager, err := net.New(ctx, logger, client, netOpts)
 	if err != nil {
 		return nil, err
 	}
@@ -107,13 +105,10 @@ func LoadHTMLPage(
 		mouse,
 		keyboard,
 	)
-
 	if err != nil {
 		return nil, err
 	}
 
-	closers = append(closers, domManager)
-
 	p = NewHTMLPage(
 		logger,
 		conn,