-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reflecting changes in the CCD #44
Conversation
Did you report 8BA and others where there are chemistry changes to the PDB. |
Updated DG9-SER link
NOTE: T0N should be fixed; this acedrg seems to have a problem with atom name having two single quotations. |
T0N fixed (by a newer acedrg). still needs tests |
T0N is only in one NMR model so I cannot test in pdb-redo. |
N8K is used in 6tg4 and 7pox. 6tg4 is good, but 7pox uses different atom names. I initially thought atom names have not been updated in 7pox, but they are also inconsistent with alt_atom_id (so updating in gemmi didn't help at all). Similarly, X1J is inconsistent with both PDB entries (5sns and 5s65). Again alt_atom_id didn't help, which is (partly) incorrect. |
I'll report those to the PDB annotators |
@drlemmus any update from the PDB? |
Not yet, I'm afraid. |
7CQ in the CCD was fixed and that in our library was updated accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks reasonable to me
In the CCD, now |
As discussed in #48, single-atom entries By the way, should we remove |
Redundant and CCD-nonexistent single atom entries |
Do we have replacements for these single atom monomers? |
Yes. They were Rh, Rh, Bi, Ta, Be, Er, respectively. Here is the summary of single-atom entries:
|
Following #40, inconsistencies from the CCD was checked.
Now, following entries are obsolete:
Following entries have been updated, because atomic compositions or bonding patterns were changed.
Note 8BA has wrong chemistry (both P-OP1 and P-OP2 were double bond) which was fixed manually.
There are some changes in following entries as well, but they couldn't be updated because of metals or borons.
Needs testing before merging.