Fixes XACT ADPCM Compression Playback #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes XACT ADPCM Compression Playback
|
Thanks for this PRs @squarebananas . @mrhelmut i've had to do a fix like this before on some projects. So i suspect it is correct. |
|
Yes, this seems relevant to me! The sample has been very welcome. I've been having crashes with XACT related to this. |
viniciusjarina
pushed a commit
to codefoco/MonoGame
that referenced
this pull request
Sep 18, 2021
Fixes XACT ADPCM Compression Playback
wihu
pushed a commit
to wihu/MonoGame
that referenced
this pull request
Jan 7, 2022
…evelop * 'develop' of https://github.com/MonoGame/MonoGame: (547 commits) remove unused reader/writer classes remove CLSCompliant(false) from internal members remove unused usings from Content readers Update 1_setting_up_your_development_environment_macos.md Update 1_setting_up_your_development_environment_ubuntu.md fixed comment for intersects method (MonoGame#7592) Enable setting 8 render targets when targetting Windows (MonoGame#7549) added null check to Tick and Reset time elapsed Added a keyboard shortcut (F2) to rename a file. Fixes XACT ADPCM Compression Playback (MonoGame#7564) Added Play/Pause/Resume/Stop To Existing Tests Fixes EffectParameter SetValue Using Int For Float Parameters Fixes XACT Cue.IsPlaying Behaviour When Paused Null song parameters are not allowed in XNA (MonoGame#7558) Add GitHub Actions (MonoGame#7511) Optimized ApplyAlpha by removing two unnecessary arithmetic operations (MonoGame#7555) [Content Pipeline] Fix library names when packaging the nuget Removed PS Vita support (MonoGame#7531) Fix iOS GamePlatform to run pending background tasks MonoGame#7520 (MonoGame#7522) cask is no longer a brew command (MonoGame#7543) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix XACT ADPCM compression playback. More details on the issue can be found here (the issue also includes Non-XACT playback which remains broken until FFMPEG is fixed, this only fixes XACT): #5662
The fix was originally posted by @tomspilman in 2018 here:
#5662 (comment)
The issue relates to XAudio projects, however the same fix is required for OpenAL projects as well.
For demonstration purposes please see the AdpcmAlignment project within here:
https://github.com/squarebananas/MonoGameSamplesForIssues