Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup DesktopGL project #6772

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Setup DesktopGL project #6772

merged 1 commit into from
Jun 25, 2019

Conversation

harry-cpp
Copy link
Member

@harry-cpp harry-cpp commented Jun 25, 2019

Notes:

  • Restored the csproj ignore to .gitignore, we should force csproj files until move is done
  • Added DesktopGL project
    • This targets both .netstandard2.0 and .net451, and this means that the nuget will be referencable by older projects as well
  • Project file is a nuget package file at the same time :)
  • I'm cheating because this isn't connected to the build bot, and is not breaking any stuff as our project name was never .DesktopGL.csproj

How to build nuget:

dotnet restore MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj
msbuild /t:Pack /p:Version=3.8.0.3 MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj

CC. @Jjagg

@mrhelmut
Copy link
Contributor

net4 would be cool to have a compatibility toward WinXP, though it's not a big deal considering that Steam has stopped supporting it.
If it's holding anything back to move forward, let's just bid farewell to Net4.0 and WinXP (it has bad OpenGL drivers anyway).

@harry-cpp
Copy link
Member Author

Yea, I actually need .NET 4.5.1 actually for corert stuff.

@mrhelmut
Copy link
Contributor

So goodbye WinXP, that's a problem solved in some way. =P
Can't wait for a smoother CoreRT support!

MonoGame.Framework.DesktopGL.sln Show resolved Hide resolved
MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj Outdated Show resolved Hide resolved
MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj Outdated Show resolved Hide resolved
MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj Outdated Show resolved Hide resolved
MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj Outdated Show resolved Hide resolved
MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj Outdated Show resolved Hide resolved
MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj Outdated Show resolved Hide resolved
MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj Outdated Show resolved Hide resolved
MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj Outdated Show resolved Hide resolved
@Jjagg
Copy link
Contributor

Jjagg commented Jun 25, 2019

Building nugets can be

dotnet restore MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj
dotnet pack -p:Version=3.8.0.3 MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj

@harry-cpp harry-cpp force-pushed the new_desktopgl branch 2 times, most recently from 6ad6a21 to 0432edb Compare June 25, 2019 10:44
@harry-cpp
Copy link
Member Author

dotnet pack

That only works on Windows, on Mac/Linux you have to use msbuild to pack multitarget framework nugets. TLDR. dotnet msbuild does not support standard .net framework compilation on non Windows platforms.

@harry-cpp harry-cpp force-pushed the new_desktopgl branch 2 times, most recently from 7c32856 to 979ab8f Compare June 25, 2019 11:22
@harry-cpp
Copy link
Member Author

@Jjagg should be good now, one thing we forgot is Framework.Net.Platform projects are still in the same folder, we should move it to a separate folder.

@Jjagg
Copy link
Contributor

Jjagg commented Jun 25, 2019

URLs in props file are still yours.

Yeah, we don't have to do Net stuff in this PR.

@harry-cpp
Copy link
Member Author

@Jjagg Yea, too many small mistakes to keep track of em. Hopefully no mistake now.

@Jjagg
Copy link
Contributor

Jjagg commented Jun 25, 2019

I tried building a game project created from the dotnet template with p2p reference to this csproj file and the MonoGamePlatform property didn't get set for my project (causing an error in MonoGame.Content.Builder).

EDIT: Maybe we should just add the property to the template directly? Anyway, that's not an issue with this PR.

@harry-cpp
Copy link
Member Author

harry-cpp commented Jun 25, 2019

I tried building a game project created from the dotnet template with p2p reference to this csproj file and the MonoGamePlatform property didn't get set for my project (causing an error in MonoGame.Content.Builder).

EDIT: Maybe we should just add the property to the template directly? Anyway, that's not an issue with this PR.

Doesn't work like that, if you are not using nuget you have to manually set MonoGamePlatform property in your project if you wanna use MGCB targets, thats normal.

@Jjagg
Copy link
Contributor

Jjagg commented Jun 25, 2019

Okay, this is good to go. Merging! :D

@Jjagg Jjagg merged commit aa1a952 into MonoGame:develop Jun 25, 2019
@harry-cpp harry-cpp deleted the new_desktopgl branch June 25, 2019 12:35
@jnoyola jnoyola mentioned this pull request Jun 25, 2019
@harry-cpp harry-cpp added this to the 3.8 Release milestone Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants