Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom ID field test improvements #2095

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Custom ID field test improvements #2095

merged 2 commits into from
Jun 18, 2019

Commits on Jun 18, 2019

  1. Split up custom PK field tests 

    This more closely aligns with the rule that a single tests should test one
thing and one thing only. Previous code tested like 4 different things in a
single test and was hard to follow.
    @wojcikstefan
    wojcikstefan committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    f8593d8 View commit details
    Browse the repository at this point in the history

  2. Use str(exc) instead of exc.message

    @wojcikstefan
    wojcikstefan committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    13dc931 View commit details
    Browse the repository at this point in the history