Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use insert_one instead of deprecated one #1899 #1944

Merged
merged 4 commits into from
Nov 13, 2018
Merged

Use insert_one instead of deprecated one #1899 #1944

merged 4 commits into from
Nov 13, 2018

Conversation

erdenezul
Copy link
Collaborator

Closes #1899

@erdenezul
Copy link
Collaborator Author

Can you please review this? @bagerard

bagerard
bagerard reviewed Nov 10, 2018
View reviewed changes
mongoengine/document.py Outdated Show resolved Hide resolved
bagerard
bagerard reviewed Nov 10, 2018
View reviewed changes
Copy link
Collaborator

@bagerard bagerard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done reviewing. Its the first time that I'm using the review feature in github, let me know in case I should have done anything differently

mongoengine/document.py Show resolved Hide resolved
mongoengine/document.py Show resolved Hide resolved
@erdenezul erdenezul merged commit 78a9420 into MongoEngine:master Nov 13, 2018
@puentesarrin puentesarrin mentioned this pull request Oct 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagerard bagerard bagerard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erdenezul @bagerard