Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Josh heartbeat monitor re-write #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Josh heartbeat monitor re-write #2

wants to merge 1 commit into from

Conversation

jcherubino
Copy link

Took a bit of a dive into QoS stuff after my googling last night and the heartbeat functionality is sort of in-built in to the QoS profiles - it's hard to understand at first so maybe not the best for readability but wanted to have a go at doing it to try and fully understand how they work!

It somewhat raises the question of if we need a global heartbeat signal that does rover wide disabling or if each critical node should just have liveliness and deadline QoS parameters that can be watched and if either occurs then it does its own connection lost stuff. Both are viable just more of a design methodology and where we think the management of the connection issues should be :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants