Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVELOP-122: Clear general statistics table #8

Conversation

matrulda
Copy link
Collaborator

This PR contains the following changes:

  • The multiqc config has been divided into 3 different configs, on for each kind of report. It is ofc up for debate if this is the best way. An alternative way would be to have a base config and then specify special case config values in the multiqc commands or in a separate configs.
  • Report changes:
    • The FastQC sequence counts section is removed from flowcell and projects reports.
    • Flowcell report:
      • All columns regarding FastQC in General Statistics are now hidden by default. This should leave only rows with sample level metrics, however, there is a bug in MultiQC (Hide empty rows in General Statistics table when opening html file MultiQC/MultiQC#835) that hinders this. It can temporarily be fixed in the Web UI by checking and unchecking a FastQC column in "Configure Columns".
      • Bcl2fastq and Interop sections will now be shown first.
    • Project report: The FastQC % duplicates column is now hidden by default.
  • An example command to run the nextflow pipeline has been added to the README.

@johandahlberg
Copy link
Contributor

Great! This looks good to me. My one question is that since we don't use nextflow/config/multiqc_hwgs_config.yaml perhaps that should be removed?

@matrulda
Copy link
Collaborator Author

Yeah, I thought we might need it in future versions, but I guess we can just add it again if that's the case. I'll remove it.

@johandahlberg johandahlberg merged commit ea16d72 into Molmed:master Feb 21, 2019
@matrulda matrulda deleted the DEVELOP-122_clear_general_statistics_table branch November 26, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants