Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove conda recipe. allow python setup.py test to run correctly #74

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Mar 4, 2019

  • removed the conda recipe b/c (a) I don't think it gets much populated by the cookiecutter, (b) isn't used in CI, and (c) makes a third place ppl need to specify deps and versions
  • some changes that allow pytest via python setup.py test. see make python setup.py test work QCElemental#39

Copy link
Collaborator

@dgasmith dgasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this as it simplifies the cognitive overhead and the conda-forge solution seems to be working as well. Will keep this open for awhile, especially for @Lnaden to weigh in.

Copy link
Collaborator

@dgasmith dgasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, merging!

@dgasmith dgasmith merged commit b7069ae into MolSSI:master Mar 26, 2019
@jchodera
Copy link

the conda-forge solution seems to be working as well.

What is "the conda-forge solution"?

@dgasmith
Copy link
Collaborator

Deploying to conda-forge rather than your own channel. We have moved many projects there and folks have had many less hitches than deploying your own. It is also managed, so much better than custom channels.

@jchodera
Copy link

Totally agree that conda-forge is the way to go if projects are free of dependencies they don't provide.

I was just wondering how the cookiecutter specifically aided people in setting up conda-forge recipes now that the development recipe is no longer used.

@dgasmith
Copy link
Collaborator

We point them to Bioconda, Omnia, and the Conda docs. We had a lot of complaints trying to figure out what the meta.yaml file is for which catalyzed their removal. From our feedback and teaching this cookiecutter to about 150 students, outside of the Bioconda/Omnia community we have not had a use case where conda-forge does not work. So it seem that the non-cf solution is an extreme edge case that can be better handled by the folks running the non-cf channels.

@loriab loriab deleted the setuppytest branch March 26, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants