Fix useFacetCallback having outdated values #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/Mojang/ore-ui into make-sure-callbacks-get-current-value
Shenato
reviewed
Mar 2, 2023
| @@ -66,14 +62,16 @@ export function useFacetCallback<M, Y extends Facet<unknown>[], T extends [...Y] | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| return useCallback( | |||
| (...args: K) => { | |||
| const values = facetsRef.current | |||
| const values = facets.map((facet) => facet.get()) | |||
There was a problem hiding this comment.
Should this be args.map()?
I'm not sure how to fix errors the the linter is throwing here.
There was a problem hiding this comment.
We should do it in the same way as in the useLayoutEffect above. Just pushed a new commit.
|
This looks good to me! great find! |
Shenato
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test demonstrates how the issue can happen, but basically if we have as the result of a subscription that a callback from a
useFacetCallbackis called, it could have outdated values.This would happen simply because the order of the subscriptions could have the internal subscription inside the
useFacetCallbackbe notified after everything else.An implication of this change, is that the call to
getwill re-execute any transformations done by auseFacetMapbut I don't expect this to be of a concern.The
useFacetRefwill potentially have the same issue, but we can investigate and address in a follow-up PR.