Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New linting rule to detect import issues #106

Merged
merged 4 commits into from
Dec 6, 2022
Merged

New linting rule to detect import issues #106

merged 4 commits into from
Dec 6, 2022

Commits on Dec 6, 2022

  1. New linting rule to detect import issues 

    As an example, we have cyclic dependencies that can cause issues with some Webpack environments.
    @pirelenito
    pirelenito committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c62b4eb View commit details
    Browse the repository at this point in the history

  2. Fix cycle dependencies, plus some further recommendations

    @pirelenito
    pirelenito committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    bbdf04e View commit details
    Browse the repository at this point in the history

  3. Removes fireEvent, that would be overwritten anyway 

    This fixes the following lint error:

```
  241:14  error  Multiple exports of name 'fireEvent'  import/export
  242:1   error  Multiple exports of name 'fireEvent'  import/export
```
    @pirelenito
    pirelenito committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c6d50bb View commit details
    Browse the repository at this point in the history

  4. Ignore rule for a case that its invalid

    @pirelenito
    pirelenito committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    45f632f View commit details
    Browse the repository at this point in the history