Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom predicate that replaces StringReader#isAllowedInUnquotedString #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

astro-angelfish
Copy link

@astro-angelfish astro-angelfish commented Jan 5, 2024

Instead of #131 with greedy charset solution, I tried another approach that allows users to define their own whitelist. It might be useful when users trying to define their own syntax on command arguments like entity selectors or something else that might accept non-ASCII characters

Usage of StringReader#readString or StringReader#readUnquotedString without any argument would lead to the default behavior, which is calling StringReader#isAllowedInUnquotedString as their whitelist predicate.

Fix #103.

@Privatech38
Copy link

This will cause problems when dealing with larger whitelists/list of allowed chars, therefor consider merging yours and #131's way of dealing with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] StringReader.readUnquotedString() does not support non-ASCII characters
2 participants