Avoid eager stringification of exception messages #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4ximumPizza
reviewed
Feb 6, 2023
| @@ -16,15 +16,15 @@ public class CommandSyntaxException extends Exception { | |||
| private final int cursor; | |||
|
|
|||
| public CommandSyntaxException(final CommandExceptionType type, final Message message) { | |||
| super(message.getString(), null, ENABLE_COMMAND_STACK_TRACES, ENABLE_COMMAND_STACK_TRACES); | |||
| super(null, null, ENABLE_COMMAND_STACK_TRACES, ENABLE_COMMAND_STACK_TRACES); | |||
There was a problem hiding this comment.
For the 2nd null, could you delete it because its a duplicate? Same for line 27?
There was a problem hiding this comment.
The second null should not be a duplicate. Since Exception does not have such a constructor, if you delete the second null, it will result in an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids stringifying exception messages eagerly to reduce the overhead on command failure.