Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file name wrong change #132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SalemCode8
Copy link

I need to explain the case clearly

I had a translation file which was called pages/auth and every time I try to import or export the translations the file name will be converted to pagauth in the Spanish Language for some reason,

until I went through the package file and found this line:
$filePath = str_replace('.'.$extension, '', str_replace($locale.DIRECTORY_SEPARATOR, '', $file));
in the SyncPhrasesAction file

which in my case will replace the es/ part with nothing in this file pages/auth to become pagauth.

after playing around with the code I found out it's meant to replace the first part of the translations file as it'll be passed to the SyncPhrasesAction as es/pages/auth.php so there no need to use the aggressive str_replace and instead use preg_replace with the ^ flag will make the function make sure that it's searching for the locale name in the start of the file name instead of the whole file name

@SalemCode8 SalemCode8 changed the title Patch 1 Fix file name wrong change Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant