Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to explain the case clearly
I had a translation file which was called pages/auth and every time I try to import or export the translations the file name will be converted to pagauth in the Spanish Language for some reason,
until I went through the package file and found this line:
$filePath = str_replace('.'.$extension, '', str_replace($locale.DIRECTORY_SEPARATOR, '', $file));
in the SyncPhrasesAction file
which in my case will replace the es/ part with nothing in this file pages/auth to become pagauth.
after playing around with the code I found out it's meant to replace the first part of the translations file as it'll be passed to the SyncPhrasesAction as
es/pages/auth.php
so there no need to use the aggressivestr_replace
and instead usepreg_replace
with the^
flag will make the function make sure that it's searching for the locale name in the start of the file name instead of the whole file name