Skip to content

Commit

Permalink
Small improvements into the source code
Browse files Browse the repository at this point in the history
  • Loading branch information
aarranz authored and Alejandro Rodriguez committed Jul 24, 2017
1 parent 5a42c1f commit 0176cfb
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions src/js_tests/styledelements/ObjectWithEventsSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
});
});

describe("dispatchEvent(eventType [, ...args])", function () {
describe("dispatchEvent(eventType[, ...args])", function () {

it("should throw error if the eventType does not exist", function () {
var eventTarget = new StyledElements.ObjectWithEvents(['click']);
Expand All @@ -76,7 +76,7 @@
}).toThrow(jasmine.any(Error));
});

it("should add an eventListener while the event is dispatching", function () {
it("should allow adding an event listeners while the event is dispatching", function () {
var eventTarget = new StyledElements.ObjectWithEvents(['click']);
var eventListener1 = function (element) {
eventTarget.addEventListener('click', eventListener2);
Expand All @@ -89,7 +89,7 @@
expect(eventListener2).toHaveBeenCalledWith(eventTarget);
});

it("should remove an eventListener while the event is dispatching", function () {
it("should allow removing event listeners while the event is dispatching", function () {
var eventTarget = new StyledElements.ObjectWithEvents(['click']);
var eventListener1 = function (element) {
eventTarget.removeEventListener('click', eventListener2);
Expand All @@ -107,7 +107,7 @@
expect(eventListener3).toHaveBeenCalledWith(eventTarget);
});

it("should call all eventListener list despite an eventListener throws error", function () {
it("should call all eventListener list despite whether an event listener thrown an error", function () {
var eventTarget = new StyledElements.ObjectWithEvents(['click']);
var eventListener1 = function (element) {
throw Error();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
{type: 'autoAction', action: BA.create_workspace({name: 'Basic concepts tutorial'})},
{type: 'simpleDescription', title: utils.gettext('WireCloud Basic Tutorial'), msg: utils.gettext('<p>This is the <em>Editor</em> view. In this view, you can use and modify your workspaces. Currently you are in a newly created workspace: <em>Basic concepts tutorial</em>. This workspace is empty, so the first step is to add some widgets.</p><div class="alert alert-info"><p>In next steps we need some widgets, so we are going to install them for you. You can safetly uninstall these widgets after finishing the tutorial.</p></div>')},

// Marketplace
// My Resources
{'type': 'autoAction', 'action': BA.uploadComponent('CoNWeT/input-box/1.0')},
{'type': 'autoAction', 'action': BA.uploadComponent('CoNWeT/youtube-browser/3.0')},
{'type': 'simpleDescription', 'title': utils.gettext('WireCloud Basic Tutorial'), 'msg': utils.gettext("<p>Ok, widgets have been installed successfuly.</p><p>Next step is to add the <em>YouTube Browser</em> widget to the workspace.</p>")},
Expand Down Expand Up @@ -110,7 +110,7 @@

{'type': 'userAction', 'msg': utils.gettext("Click <em>Wiring</em> to continue"), 'elem': BS.toolbar_button('wc-show-wiring-button'), 'pos': 'downLeft'},

// WiringEditor
// Wiring editor
{'type': 'simpleDescription', 'title': utils.gettext('WireCloud Basic Tutorial'), 'msg': utils.gettext("<p>This is the <em>Wiring Editor</em> view.</p><p>Here you can wire widgets and operators together turning your workspace into and <em>application mashup</em>.</p>")},
{'type': 'userAction', 'msg': utils.gettext("Click <em>Find components</em> to open the sidebar"), 'elem': BS.toolbar_button('we-show-component-sidebar-button'), 'pos': 'downLeft'},
{'type': 'autoAction', 'elem': BS.toolbar_button('we-show-component-sidebar-button'), 'action': BA.sleep(250)},
Expand Down
2 changes: 1 addition & 1 deletion src/wirecloud/platform/static/js/wirecloud/Workspace.js
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@
},

/**
* Creates a packaged version of this workspace and uploads it into MyTab
* Creates a packaged version of this workspace and uploads it into My
* Resources.
*
* @param {Object} options
Expand Down

0 comments on commit 0176cfb

Please sign in to comment.