Custom Dispenser Behavior addition to station-items-api-v0 #99
Conversation
There was a problem hiding this comment.
Looking on mobile, so I'm not going to review code specifics yet.
You're missing newlines at the end of files, which can make diffs more messy in the future.
Also, maybe make a new cancelable event for when dispensers are triggered and attach the interface functionality as a low priority listener instead, to allow mods more freedom in messing with dispenser behaviour.
.../main/java/net/modificationstation/stationapi/mixin/dispenser/block/DispenserBlockMixin.java
Outdated
Show resolved
Hide resolved
...dispenser-api-v0/src/main/java/net/modificationstation/stationapi/api/item/DispenseUtil.java
Outdated
Show resolved
Hide resolved
...dispenser-api-v0/src/main/java/net/modificationstation/stationapi/api/item/DispenseUtil.java
Outdated
Show resolved
Hide resolved
...dispenser-api-v0/src/main/java/net/modificationstation/stationapi/api/item/DispenseUtil.java
Outdated
Show resolved
Hide resolved
...dispenser-api-v0/src/main/java/net/modificationstation/stationapi/api/item/DispenseUtil.java
Outdated
Show resolved
Hide resolved
.../main/java/net/modificationstation/stationapi/mixin/dispenser/block/DispenserBlockMixin.java
Outdated
Show resolved
Hide resolved
.../main/java/net/modificationstation/stationapi/mixin/dispenser/block/DispenserBlockMixin.java
Outdated
Show resolved
Hide resolved
...t/modificationstation/stationapi/mixin/dispenser/block/entity/DispenserBlockEntityMixin.java
Outdated
Show resolved
Hide resolved
...t/modificationstation/stationapi/mixin/dispenser/block/entity/DispenserBlockEntityMixin.java
Outdated
Show resolved
Hide resolved
matthewperiut
changed the title
...n-items-v0/src/main/java/net/modificationstation/stationapi/api/dispenser/DispenseEvent.java
Outdated
Show resolved
Hide resolved
...s-v0/src/main/java/net/modificationstation/stationapi/api/dispenser/ItemDispenseContext.java
Outdated
Show resolved
Hide resolved
...ems-v0/src/main/java/net/modificationstation/stationapi/api/item/CustomDispenseBehavior.java
Outdated
Show resolved
Hide resolved
...in/java/net/modificationstation/stationapi/impl/dispenser/CustomDispenseBehaviorHandler.java
Outdated
Show resolved
Hide resolved
| public final ItemStack itemStack; | ||
| private ItemStack shotItemStack; | ||
| public byte xDir = 0; | ||
| public byte zDir = 0; |
There was a problem hiding this comment.
What's the point of making these two non-final if they're populated to the same value always? Also, what's the point of using two bytes when we have the Direction enum?
There was a problem hiding this comment.
Yeah, they can be final. The reason for not using the direction enum was straight up so that the code was 1:1 to the existing dispenser code, and I think they should stay this way, because really not much is being lost for it being this way. maybe a byte of memory lol
| } | ||
| } | ||
|
|
||
| private void populateData() { |
There was a problem hiding this comment.
What's the point of this entire method? Can't it be fully moved to the constructor?
There was a problem hiding this comment.
Yeah, that's a good point, I had multiple constructors at one point is why
| public int z; | ||
| public double xVel; | ||
| public double yVel; | ||
| public double zVel; |
There was a problem hiding this comment.
What's the point of making these six non-final if they're always calculated to the same value?
There was a problem hiding this comment.
Sure, I think they can be final
I've tried to make a dispenser modification interface as neatly as possible for an API, I'd be happy to make changes! Here's a demo:
dispenser-demo.mp4