Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worldgen API v0 [Part 3] #75

Merged
merged 6 commits into from
Oct 29, 2023

Conversation

paulevsGitch
Copy link
Contributor

That PR adds tall Overworld support (since dimension can have any height).
Overworld require mixin to change height (same as before), but now any height should work correctly.
PR is ready for review, but probably require some testing

2023-10-24_19 08 08

@paulevsGitch
Copy link
Contributor Author

I added additional functionality into this PR - BiomeModificationEvent. It is called for each biome in the dimension and can be used for transforming biomes content (for example add more entities into the biome). Event can be called like this:

@EventListener
public void testBiomeModification(BiomeModificationEvent event) {
	// event.level - current level
	// event.biome - current biome
}

Additionally StationDimension now can provide a list of containing biomes, so modded dimensions can implement that and this event will work for any dimension. For vanilla worlds it will work automatically

@paulevsGitch
Copy link
Contributor Author

I also fixed incorrect class in biome builder, for some reason it was text entity from Java instead of proper BaseEntity from MC

@mineLdiver mineLdiver merged commit cfc7682 into ModificationStation:master Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants