Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worldgen API v0 [Part 2] #68

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

paulevsGitch
Copy link
Contributor

This is the second worldgen PR. That one contains feature system. It also fixes some mistakes in original PR.

Basically all features are vanilla structure wrappers with simple hierarchy (used for some vanilla features), like that:

public static final Structure LAVA_LAKE_SCATTERED = new BottomWeightedScatter(
    new WeightedStructure(LAVA_LAKE, 8), 1, 8, 128
);

There are several scatter structures that will place inner structure, weighted structure that will deny placement based on weight and so on. Scatters support different techniques and can be used for Overworld, Nether, caves, custom dimensions and so on.

This PR is ready for review

2023-10-18_13 03 09

2023-10-18_13 21 55

@paulevsGitch
Copy link
Contributor Author

Most default structures are located in DefaultStructures class, so making a biome that contains vanilla features should be easy

Copy link
Member

@mineLdiver mineLdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment though

Copy link
Member

@mineLdiver mineLdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. If this is ready to get merged, let's merge.

@mineLdiver mineLdiver merged commit f08037f into ModificationStation:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants