Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement toggle for displaying thumbnail image in the background #315

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

fheck
Copy link
Contributor

@fheck fheck commented Dec 17, 2020

I looked into implementing it myself and found it relatively easy. I hope I found everything I needed to adapt. If there is anything I missed, just tell me and I will try to fix it.

Implements #224

@ShankarBUS
Copy link
Member

Wow!

Thank you so much mate! I was distracted away by some other things. Thanks again.

I will look into it as the first thing in the morning. Keep this for now ❤

Copy link
Member

@ShankarBUS ShankarBUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please correct those suggestions?
Or else I could do that after merging.

ModernFlyouts/Controls/SessionControl.xaml.cs Outdated Show resolved Hide resolved
ModernFlyouts/Controls/SessionControl.xaml.cs Outdated Show resolved Hide resolved
ModernFlyouts/Controls/SessionControl.xaml.cs Outdated Show resolved Hide resolved
ModernFlyouts/Controls/SessionControl.xaml.cs Outdated Show resolved Hide resolved
@ShankarBUS
Copy link
Member

Wow! That was quick.

@Samuel12321, merge this marvel!

@fheck
Copy link
Contributor Author

fheck commented Dec 17, 2020

I have made the requested changes. I have some experience with C#, but I haven't done much with xmal, so I wasn't aware there is a simpler way.
That was a fun evening project, so I just did it now😃.

@ShankarBUS
Copy link
Member

Also thanks for the free translations lol. Saves us some time.

@fheck
Copy link
Contributor Author

fheck commented Dec 17, 2020

I only speak English and German, so I can't help with the other ones, but I'm happy to do those I know.

Copy link
Member

@Samuel12321 Samuel12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks so much for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants