Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Key release #306

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Added Key release #306

merged 2 commits into from
Dec 15, 2020

Conversation

Renzo904
Copy link
Contributor

@Renzo904 Renzo904 commented Dec 14, 2020

This should fix #305, the toggles of the locks keys are still hooking the key even when you are holding it, so when you hold it, it shows the "LockKey is off" and "LockKey is on" again and again. Also, feel free of edit my code, i'm still getting used to C#😅😅

Copy link

@kotx kotx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few typos.

ModernFlyouts/Flyout Helpers/LockKeysFlyoutHelper.cs Outdated Show resolved Hide resolved
@ShankarBUS
Copy link
Member

Looks good. Thanks @Renzo904!

@Renzo904
Copy link
Contributor Author

Could you merge it @Samuel12321?

@ShankarBUS
Copy link
Member

@Renzo904,

I'll do that.

@ShankarBUS ShankarBUS merged commit bc1b72a into ModernFlyouts-Community:main Dec 15, 2020
@ShankarBUS ShankarBUS mentioned this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Pressing and holding caps lock toggles flyout twice.
3 participants