Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem this is trying to solve is that the old
USVSParameters
structure,USVFSInitParameters()
andUSVFSUpdateParams()
can't be modified without breaking the ABI. I wanted to add the spawn delay parameter, but then the DLL wouldn't be compatible with 2.2.1. I don't want to pick and choose changes to release patches to usvfs.This PR completely deprecates
USVSParameters
as well as its associated functions, and changes all the internals to use the newusvfsParameters
instead. The two structures are basically identical (except for the new spawn delay), butusvfsParameters
is not exposed, it's just an opaque pointer. It also starts a long-term process of adding theusvfs
prefix to the public interface, because stuff likeGetLogMessages()
isn't great.Specifically, these are deprecated:
ConnectVFS()
, replaced byusvfsConnectVFS()
.CreateVFS()
, replaced byusvfsCreateVFS()
.USVFSInitParameters()
, replaced byusvfsCreateParameters()
and its associated functions.USVFSUpdateParams()
, replaced byusvfsUpdateParameters()
USVSParameters
structure, replaced byusvfsParameters
CreateHookContext()
, replaced byusvfsCreateHookContext()
(seems to be only used for internal tests)