Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameters structure #23

Merged
merged 4 commits into from
Oct 11, 2019
Merged

Conversation

isanae
Copy link

@isanae isanae commented Oct 10, 2019

The problem this is trying to solve is that the old USVSParameters structure, USVFSInitParameters() and USVFSUpdateParams() can't be modified without breaking the ABI. I wanted to add the spawn delay parameter, but then the DLL wouldn't be compatible with 2.2.1. I don't want to pick and choose changes to release patches to usvfs.

This PR completely deprecates USVSParameters as well as its associated functions, and changes all the internals to use the new usvfsParameters instead. The two structures are basically identical (except for the new spawn delay), but usvfsParameters is not exposed, it's just an opaque pointer. It also starts a long-term process of adding the usvfs prefix to the public interface, because stuff like GetLogMessages() isn't great.

Specifically, these are deprecated:

  • ConnectVFS(), replaced by usvfsConnectVFS().
  • CreateVFS(), replaced by usvfsCreateVFS().
  • USVFSInitParameters(), replaced by usvfsCreateParameters() and its associated functions.
  • USVFSUpdateParams(), replaced by usvfsUpdateParameters()
  • USVSParameters structure, replaced by usvfsParameters
  • CreateHookContext(), replaced by usvfsCreateHookContext() (seems to be only used for internal tests)

deprecated everything having to do with USVFSParameters
removed delayProcess from the old stuff to preserve ABI
@isanae isanae merged commit 4e476ec into ModOrganizer2:Develop Oct 11, 2019
@isanae isanae deleted the new-parameters branch January 14, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant