Add startDownloadNexusFileForGame

[JonathanFeenstra]

Requested by @FlayaN on Discord

[qudix]

I think it would be ideal to avoid function overloads, especially with virtual functions. The compiler is free to put them in any order which is annoying. Maybe something like startDownloadNexusFileEx or startDownloadNexusGameFile

[JonathanFeenstra]

We already use function overloads in some other places though, including for virtual functions like IModList::setActive. Would it still be better to rename the function despite the inconsistency?

[qudix]

Yes, current uses does not preclude changing course for the better.

[Holt59]

I think it would be ideal to avoid function overloads, especially with virtual functions. The compiler is free to put them in any order which is annoying. Maybe something like startDownloadNexusFileEx or startDownloadNexusGameFile

I don't really think that's an issue - The way the code is currently written, most MO2 updates breaks the uibase API anyway so the order does not really matter.

[Holt59]

I would use the game ID instead of the game name, I think those are less likely to be changed in the future (if I remember correctly, Nexus has changed the game short names a few times in the past which was kind of annoying for MO2).

[JonathanFeenstra]

Internally, the function uses the game name anyway (QString("nxm://%1/mods/%2/files/%3").arg(gameName).arg(modID).arg(fileID))), so there's no way around that unfortunately. I think Nexus is now more careful with these kind of changes though, at least in ModOrganizer2/modorganizer#2138 we were notified in advance.