-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: metrics using single feature truth #832
base: main
Are you sure you want to change the base?
Conversation
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-832-kjr23xpl.web.app |
@Alessandro100 Can we add Flex as a subgroup? It's all features in Flexible services except Continuous Stops Also to be clear, we'll use this for internal analytics, but not the public facing search (as discussed in #806 - there's alignment in using tags for extensions like Flex and Fares v2 outside of features) |
@Alessandro100 It looks like the changes to features from FEATURES.md are not reflected here: https://github.com/MobilityData/gtfs-validator/blob/master/docs/FEATURES.md#feature-migration |
@cka-y Any clue about why the counts have changed for the ones where only the name has changed (e.g Bike Allowed, or Text-to-Speech) |
@emmambd I'm not sure I fully understand the question, but here's some context that might help:
Does this answer your question? If not, could you clarify or provide more details? |
@cka-y Your second point does - I forgot we've added a fair number of feeds and so it makes sense we're seeing significantly more text-to-speech feeds. Thanks! |
closes #820
Summary:
Updates the feature support to 6.0 for the gtfs metrics. Also consolidates the Features data to a source of truth in the frontend. Added sub group feature to metrics to accommodate Fares V2 and Flex
Expected behavior:
Metrics in the features should have no empty groups and should be displayed correctly
Testing tips:
Go to the GTFS metrics page (Feeds / Features) and play around with to make sure the features are displaying correctly
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anythingSubgroup depicted as Icon + tooltip
Screenshot with prod analytics