Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db-gen script not running correctly with Python 3.11 due to sqlacodegen #70

Closed
indraneel opened this issue Aug 8, 2023 · 1 comment · Fixed by #71
Closed

db-gen script not running correctly with Python 3.11 due to sqlacodegen #70

indraneel opened this issue Aug 8, 2023 · 1 comment · Fixed by #71
Assignees
Labels
bug Something isn't working

Comments

@indraneel
Copy link

Describe the bug

When running db-gen.sh with Python 3.11, seeing this error:

 File "/Users/indraneel/opt/anaconda3/envs/mdfeed/lib/python3.11/site-packages/sqlacodegen/codegen.py", line 9, in <module>
    from inspect import ArgSpec

Steps/Code to Reproduce

  1. Follow setup steps in Readme
  2. Use Python 3.11
  3. Try to run db-gen.sh

Expected Results

db-gen.sh should run

Actual Results

 File "/Users/indraneel/opt/anaconda3/envs/mdfeed/lib/python3.11/site-packages/sqlacodegen/codegen.py", line 9, in <module>
    from inspect import ArgSpec

Screenshots

No response

Files used

No response

Additional notes

From the sqlacodegen repo, it seems like the issue is fixed in the v3 release candidate agronholm/sqlacodegen#239 (comment)

So the paired fix to this will be adding that version to requirements.txt

@indraneel indraneel added the bug Something isn't working label Aug 8, 2023
@welcome
Copy link

welcome bot commented Aug 8, 2023

Thanks for opening your first issue in this project! If you haven't already, you can join our slack and join the #mobility-database channel to meet our awesome community. Come say hi 👋!

Welcome to the community and thank you for your engagement in open source! 🎉

@indraneel indraneel self-assigned this Aug 8, 2023
@indraneel indraneel changed the title db-gen script not running correctly db-gen script not running correctly with Python 3.11 due to sqlacodegen Aug 8, 2023
indraneel pushed a commit that referenced this issue Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant