Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for GTFS-ServiceChanges v3.1 - NOT FOR PRODUCTION USE #58

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

barbeau
Copy link
Member

@barbeau barbeau commented Feb 25, 2020

Do not merge - work in progress

Based on the .proto from MobilityData/transit#47, which is subject to change.

NOT FOR PRODUCTION USE - FOR PROTOYPING ONLY

If you start using these bindings, please comment below!

Java

If you're using Maven to manage your dependencies in your project:

  1. Clone this project and check out this branch (service-changes)
  2. cd java - change to the Java subdirectory
  3. mvn install - build the Java bindings and install them to your local Maven repo
  4. Change your pom.xml to point to the following:
    <groupId>io.mobilitydata.transit</groupId>
    <artifactId>gtfs-realtime-bindings</artifactId>
    <version>0.0.6-SNAPSHOT</version>

If you're not using Maven to build your own project:

  1. mvn package
  2. Look in target directory - you should see a gtfs-realtime-bindings-0.0.6-SNAPSHOT.jar file there you can use as a library for your project

@barbeau barbeau changed the title Alpha version of GTFS-ServiceChanges - NOT FOR PRODUCTION USE Alpha version of GTFS-ServiceChanges v3.1 - NOT FOR PRODUCTION USE Feb 27, 2020
@barbeau barbeau changed the title Alpha version of GTFS-ServiceChanges v3.1 - NOT FOR PRODUCTION USE Update for GTFS-ServiceChanges v3.1 - NOT FOR PRODUCTION USE Feb 27, 2020
@barbeau
Copy link
Member Author

barbeau commented Mar 30, 2020

I've added a field for StopTime to FeedEntity so stop times can be added to the feed. This was an oversight in the original draft .proto.

@barbeau
Copy link
Member Author

barbeau commented Mar 30, 2020

I've moved StopTime to be a repeated entity within Trip - otherwise there was no way to tie StopTimes to a Trip. See MobilityData/transit#47 (comment).

@barbeau
Copy link
Member Author

barbeau commented Apr 3, 2020

I just added the two new route_types from google/transit#174 to the bindings for service changes.

@barbeau
Copy link
Member Author

barbeau commented Apr 8, 2020

I removed stop_id from stop_time_properties - NewStops should only be used in new Trips, not TripUpdates

@barbeau
Copy link
Member Author

barbeau commented Apr 9, 2020

I've added Trip.start_date to specify the date when a new trip starts.

@barbeau
Copy link
Member Author

barbeau commented Apr 9, 2020

I just pushed a fix for a field name: biked_allowed -> bikes_allowed

See:
* Allow repeated start_date for new Trips - MobilityData/transit@e30983f
* Trip.replaces_trip_id -> TripUpdate.replaced_by_trip_id - MobilityData/transit@9c5af29
@barbeau
Copy link
Member Author

barbeau commented Apr 14, 2020

I just pushed two change to the bindings - see:

@mpaine-act
Copy link

mpaine-act commented Oct 31, 2023

I have question about support for start_date. When the trip starts a few minutes before midnight but is still considered part of the current day in which it runs 99% of the trip. Should the start_date be null, the previous date or the current date? Also, should start_time be listed in either case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants