-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for GTFS-ServiceChanges v3.1 - NOT FOR PRODUCTION USE #58
base: master
Are you sure you want to change the base?
Conversation
Based on the .proto from MobilityData/transit#47
Otherwise you can't add any stop times to the feed
I've added a field for StopTime to FeedEntity so stop times can be added to the feed. This was an oversight in the original draft .proto. |
I've moved StopTime to be a repeated entity within Trip - otherwise there was no way to tie StopTimes to a Trip. See MobilityData/transit#47 (comment). |
I just added the two new |
I removed |
I've added |
I just pushed a fix for a field name: |
...and the static validator
See: * Allow repeated start_date for new Trips - MobilityData/transit@e30983f * Trip.replaces_trip_id -> TripUpdate.replaced_by_trip_id - MobilityData/transit@9c5af29
I just pushed two change to the bindings - see:
|
I have question about support for start_date. When the trip starts a few minutes before midnight but is still considered part of the current day in which it runs 99% of the trip. Should the start_date be null, the previous date or the current date? Also, should start_time be listed in either case? |
Do not merge - work in progress
Based on the .proto from MobilityData/transit#47, which is subject to change.
NOT FOR PRODUCTION USE - FOR PROTOYPING ONLY
If you start using these bindings, please comment below!
Java
If you're using Maven to manage your dependencies in your project:
service-changes
)cd java
- change to the Java subdirectorymvn install
- build the Java bindings and install them to your local Maven repopom.xml
to point to the following:If you're not using Maven to build your own project:
mvn package
target
directory - you should see agtfs-realtime-bindings-0.0.6-SNAPSHOT.jar
file there you can use as a library for your project