-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-13337] Add Pydantic v2 support #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 15:16
80904ea
to
95d1c5b
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 15:29
95d1c5b
to
f05c058
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 15:35
f05c058
to
a095d80
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 15:39
a095d80
to
9ed592b
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 15:40
9ed592b
to
a66f9d9
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 15:43
a66f9d9
to
5d04b0f
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 15:49
5d04b0f
to
caf2673
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 15:57
caf2673
to
45453ae
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 16:23
45453ae
to
f86a4fc
Compare
dolfinus
force-pushed
the
feature/DOP-13337
branch
from
March 5, 2024 16:28
f86a4fc
to
ef574e7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14 +/- ##
===========================================
- Coverage 96.62% 93.51% -3.12%
===========================================
Files 3 3
Lines 89 108 +19
Branches 8 16 +8
===========================================
+ Hits 86 101 +15
- Misses 3 5 +2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
maxim-lixakov
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Allow using horizon-hwm-store with both Pydantic v1 and v2 (thanks to etl-entities 2.3 release). Because Horizon client is inherited from
pydantic.BaseModel
and notpydantic.v1.BaseModel
, this introduced few quirks to validation.Added tests for both Pydantic versions to CI workflow.
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)