Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13156] - add changelog section #10

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Feb 15, 2024

Change Summary

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov self-assigned this Feb 15, 2024
@maxim-lixakov
Copy link
Contributor Author

Поправил команды:
Remove content above the version number heading in the ${VERSION}.rst file
sed -i '' "0,/^.*towncrier release notes start/d" "docs/changelog/${VERSION}.rst"

Update Changelog Index
sed -i '' -E "s/DRAFT/DRAFT\n ${VERSION}/" "docs/changelog/index.rst"

из последнего шаблона в onetl, так как на MacOS они отличаются

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (3b66c35) to head (0388fbd).
Report is 52 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #10   +/-   ##
========================================
  Coverage    96.62%   96.62%           
========================================
  Files            3        3           
  Lines           89       89           
  Branches         8        8           
========================================
  Hits            86       86           
  Misses           3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/conf.py Show resolved Hide resolved
@dolfinus
Copy link
Member

Добавь в .github/workflows/release.yml шаги с конвертацией changelog в markdown, можно утащить например из onetl

CONTRIBUTING.rst Outdated Show resolved Hide resolved
@maxim-lixakov maxim-lixakov merged commit 2be5b7c into develop Feb 16, 2024
14 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-13156 branch February 16, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants