Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/save visual #85

Merged
merged 27 commits into from
Mar 20, 2024
Merged

Feature/save visual #85

merged 27 commits into from
Mar 20, 2024

Conversation

blondered
Copy link
Collaborator

@blondered blondered commented Feb 11, 2024

  • Added saving and loading to VisualApp
  • Added pd.DataFrame support for reco parameter in VisualApp
  • Corrected app classes inheritance and construction
    Closes Visual analysis #65

@blondered blondered requested a review from feldlime February 11, 2024 12:58
@blondered blondered self-assigned this Feb 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (f225e58).
Report is 35 commits behind head on main.

❗ Current head f225e58 differs from pull request most recent head 8d9b999. Consider uploading reports for the commit 8d9b999 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #85    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           45        51     +6     
  Lines         2242      2690   +448     
==========================================
+ Hits          2242      2690   +448     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
@blondered blondered linked an issue Feb 26, 2024 that may be closed by this pull request
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Show resolved Hide resolved
rectools/visuals/visual_app.py Show resolved Hide resolved
@blondered blondered marked this pull request as ready for review March 18, 2024 15:02
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
rectools/visuals/visual_app.py Outdated Show resolved Hide resolved
@blondered blondered merged commit 3a2f0fb into main Mar 20, 2024
7 checks passed
@blondered blondered deleted the feature/save_visual branch March 20, 2024 21:11
blondered added a commit that referenced this pull request Sep 23, 2024
- Added saving and loading to `VisualApp`
- Added pd.DataFrame support for `reco` parameter in `VisualApp`
- Corrected app classes inheritance and construction
Closes #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual analysis
3 participants