Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies and examples update #54

Merged
merged 11 commits into from
Oct 27, 2023
Merged

Dependencies and examples update #54

merged 11 commits into from
Oct 27, 2023

Conversation

blondered
Copy link
Collaborator

@blondered blondered commented Oct 26, 2023 •
edited
Loading

  • Removed markdown from dependencies
  • Updated examples
  • Fixed missing copy for features in implicit als

@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #54 (3a370e9) into main (9b3992e) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 3a370e9 differs from pull request most recent head 902b809. Consider uploading reports for the commit 902b809 to get more accurate results

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         2242      2335   +93     
=========================================
+ Hits          2242      2335   +93
Files Coverage Δ
rectools/compat.py 100.00% <100.00%> (ø)
rectools/metrics/classification.py 100.00% <100.00%> (ø)
rectools/metrics/diversity.py 100.00% <100.00%> (ø)
rectools/model_selection/__init__.py 100.00% <100.00%> (ø)
rectools/model_selection/last_n_split.py 100.00% <100.00%> (ø)
rectools/model_selection/random_split.py 100.00% <100.00%> (ø)
rectools/model_selection/splitter.py 100.00% <100.00%> (ø)
rectools/model_selection/time_split.py 100.00% <100.00%> (ø)
rectools/models/__init__.py 100.00% <100.00%> (ø)
rectools/models/dssm.py 100.00% <100.00%> (ø)
... and 6 more

@blondered blondered requested a review from feldlime October 26, 2023 21:00
@blondered blondered self-assigned this Oct 26, 2023
@blondered blondered marked this pull request as ready for review October 27, 2023 13:19
@feldlime feldlime merged commit 5a5247e into main Oct 27, 2023
@feldlime feldlime deleted the feature/update_examples branch October 27, 2023 18:15
blondered added a commit that referenced this pull request Sep 23, 2024
@blondered
Dependencies and examples update (#54)
5d5b263 
- Removed `Markdown` from dependencies
- Updated examples
- Fixed missing `copy` for features in implicit als
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feldlime feldlime feldlime approved these changes

Assignees

@blondered blondered

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blondered @feldlime