Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit version update #45

Merged
merged 19 commits into from
Oct 4, 2023
Merged

Implicit version update #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f6800ba
fixed cyclic imports
Oct 2, 2023
a374c28
updated implicit to 0.7.1
Oct 2, 2023
7f74554
updated implicit wrappers
Oct 2, 2023
7803fe4
Merge branch 'main' into feature/update_implicit
Oct 2, 2023
e647553
updated poetry version in readme
Oct 2, 2023
161d27e
rewrote separate features training
Oct 3, 2023
e0c038f
fixed Matrix format for features in GPU als
Oct 3, 2023
5f728d1
linters
Oct 3, 2023
6e7aa13
updated changelog
Oct 4, 2023
3ac9d7a
fixed als tests
Oct 4, 2023
a1aad08
fixed poetry version in README.md
blondered Oct 4, 2023
533149e
fixed implicit version in pyproject.toml
Oct 4, 2023
b881797
Update CHANGELOG.md
blondered Oct 4, 2023
46ed635
fixed dtype in als test
Oct 4, 2023
75937fb
updated lock file
Oct 4, 2023
ea0a035
minor comment fixes
Oct 4, 2023
6bc42ee
refactor AlternatingLeastSquares confused classes
Oct 4, 2023
2a8d7af
linters
Oct 4, 2023
cec82e0
fixed coverage
Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0


## Unreleased

### Added
- Added `MRR (Mean Reciprocal Rank)` to `metrics` ([#29](https://github.com/MobileTeleSystems/RecTools/pull/29))
- Added `F1beta`, `MCC (Matthew correlation coefficient)` to `metrics` ([#32](https://github.com/MobileTeleSystems/RecTools/pull/32))
- Added `LastNSplitter` to `model_selection` ([#33](https://github.com/MobileTeleSystems/RecTools/pull/32))
- Added random `KFoldSplitter` to `model_selection` ([#31](https://github.com/MobileTeleSystems/RecTools/pull/31))
-

### Changed
- Bumped `implicit` version to 0.7.1 ([#45](https://github.com/MobileTeleSystems/RecTools/pull/45))
- Bumped `poetry` version to 1.4.0 for github workflows ([#43](https://github.com/MobileTeleSystems/RecTools/pull/43))
- Updated dependencies ([#43](https://github.com/MobileTeleSystems/RecTools/pull/43))
- Moved `nmslib` from main dependencies to extras ([#36](https://github.com/MobileTeleSystems/RecTools/pull/36))
- Added base `Splitter` class to construct data splitters ([#31](https://github.com/MobileTeleSystems/RecTools/pull/31))
- Updated notebooks in `examples` ([#44](https://github.com/MobileTeleSystems/RecTools/pull/44))

### Fixed
- Fixed bugs with new version of `pytorch_lightning` ([#43](https://github.com/MobileTeleSystems/RecTools/pull/43))
- Fixed `pylint` config for new version ([#43](https://github.com/MobileTeleSystems/RecTools/pull/43))
- Fixed CI ([#40](https://github.com/MobileTeleSystems/RecTools/pull/40)) ([#34](https://github.com/MobileTeleSystems/RecTools/pull/34))
- Fixed cyclic imports ([#45](https://github.com/MobileTeleSystems/RecTools/pull/45))

- Mean Reciprocal Rank metric
### Removed
- Temporarily removed support for fitting ALS model with features together ([#45](https://github.com/MobileTeleSystems/RecTools/pull/45))
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ To install all requirements run
```
make install
```
You must have `python3` and `poetry` installed.
You must have `python3` and `poetry==1.4.0` installed.

For autoformatting run
```
make autoformat
make format
```

For linters check run
Expand Down
219 changes: 133 additions & 86 deletions poetry.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ numpy = ">=1.19.5, <2.0.0"
pandas = ">=0.25.3, <2.0.0"
scipy = "^1.5.4"
tqdm = "^4.27.0"
implicit = "0.4.4"
implicit = "^0.7.1"
attrs = ">=19.1.0,<22.0.0"
typeguard = "^2.0.1"
lightfm = "1.17"
Expand Down
2 changes: 1 addition & 1 deletion rectools/metrics/diversity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
import pandas as pd

from rectools import Columns
from rectools.metrics import PairwiseDistanceCalculator
from rectools.utils import select_by_type

from .base import MetricAtK
from .distances import PairwiseDistanceCalculator


@attr.s
Expand Down
Loading