Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mean_reciprocal_rank #29

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Conversation

groundmax
Copy link
Collaborator

Добавил расчет метрики Mean Reciprocal Rank
По скорости / памяти не замерял, может и есть пути лучше. Если есть предложения по оптимизации, то готов выслушать :)

В некоторых расчетах метрик убрал сортировку в группировке и убрал еще некоторые неточности по ходу, которые замечал.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #29 (2eb3e83) into main (82351c2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        41    +8     
  Lines         2031      2119   +88     
=========================================
+ Hits          2031      2119   +88     
Impacted Files Coverage Δ
rectools/metrics/__init__.py 100.00% <100.00%> (ø)
rectools/metrics/ranking.py 100.00% <100.00%> (ø)
rectools/tools/__init__.py 100.00% <0.00%> (ø)
rectools/utils/__init__.py 100.00% <0.00%> (ø)
rectools/models/__init__.py 100.00% <0.00%> (ø)
rectools/model_selection/__init__.py 100.00% <0.00%> (ø)
rectools/models/utils.py 100.00% <0.00%> (ø)
rectools/__init__.py 100.00% <0.00%> (ø)
rectools/dataset/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@feldlime feldlime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pull request

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sharthZ23 sharthZ23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lets merge

@sharthZ23 sharthZ23 merged commit 5bed13c into main Feb 16, 2023
@sharthZ23 sharthZ23 deleted the feature/mean_reciprocal_rank branch February 16, 2023 07:55
blondered pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants