-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configs for simple models #178
Configs for simple models #178
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/model_configs #178 +/- ##
=======================================================
Coverage 100.00% 100.00%
=======================================================
Files 56 56
Lines 3519 3555 +36
=======================================================
+ Hits 3519 3555 +36 ☔ View full report in Codecov by Sentry. |
Hi, thanks for PR! |
By this I wanted to say that "additional" sounds like "optional", but these configs are not "optional" and hence not "additional". So, please, give to this PR some meaningful name, and better do not connect it with the branch name since it's already different. You can name it |
268268b
into
MobileTeleSystems:feature/model_configs
- Added model configs for `EASE`, `Random` and `PureSVD` models - Moved `RandomState` serialization to models/base.py
Description
EASE
,Random
andPureSVD
modelsRandomState
serialization to models/base.pyType of change