Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/DQ and R-Precision #155

Merged
merged 63 commits into from
Jul 1, 2024
Merged

Feature/DQ and R-Precision #155

merged 63 commits into from
Jul 1, 2024

Conversation

blondered
Copy link
Collaborator

@blondered blondered commented Jun 23, 2024 •
edited
Loading

Daria Tikhonovich added 30 commits May 5, 2024 23:43
added pauc to ranking
e5c4ce8
added naive insufficient recs check
5a919ce
changed insufficient logic
dc523f9
calc test passing
f697fd5
prepared pAUC with tests first version
7d152cd
moved pauc to separate module
759fb07
fixed print
55426bb
pap prototype added
b4e82d7
finished pap tests
3725107
introduced auc fitted
7657acc
added _calc_partial_roc_auc to _AUCMetric
de507ec
cleaned methods
5a16ab4
enum and docstrings
721d081
changed copy logic
0209aff
linters and docs
6554a0b
fixed docstrings
95bed7d
added pauc and pap description and articles
ea75dbd
fixed typo
870bb43
added math to docstrings
6e2958a
added parameters to docstrings
297d651
added examples
e8af902
format examples
5d8cd50
fixed examples
e2fb4a7
docs render fixes
9ff55bb
added scroting test
c165a91
small docs fix
df2275a
small fixes
850908a
pylint max statements
3f50551
Merge branch 'main' of https://github.com/MobileTeleSystems/RecTools …
e5c8038 
…into feature/pauc
small refactor
7937e7b
@blondered blondered requested a review from feldlime June 23, 2024 15:28
@codecov Codecov
Copy link

codecov bot commented Jun 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (aeda4db).
Report is 68 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##              main      #155     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        55     +10     
  Lines         2242      3296   +1054     
===========================================
+ Hits          2242      3296   +1054

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blondered blondered changed the title Feature/new metrics Feature/DQ and R-Precision Jun 23, 2024
feldlime
feldlime reviewed Jun 23, 2024
View reviewed changes
README.md Show resolved Hide resolved
rectools/metrics/__init__.py Outdated Show resolved Hide resolved
rectools/metrics/dq.py Outdated Show resolved Hide resolved
rectools/metrics/dq.py Outdated Show resolved Hide resolved
rectools/metrics/dq.py Outdated Show resolved Hide resolved
rectools/metrics/dq.py Outdated Show resolved Hide resolved
rectools/metrics/dq.py Outdated Show resolved Hide resolved
rectools/metrics/dq.py Outdated Show resolved Hide resolved
rectools/metrics/dq.py Outdated Show resolved Hide resolved
rectools/metrics/scoring.py Outdated Show resolved Hide resolved
feldlime
feldlime requested changes Jul 1, 2024
View reviewed changes
rectools/metrics/scoring.py Outdated Show resolved Hide resolved
feldlime
feldlime previously approved these changes Jul 1, 2024
View reviewed changes
@blondered blondered merged commit 0699727 into main Jul 1, 2024
9 checks passed
@blondered blondered deleted the feature/new_metrics branch July 1, 2024 12:40
blondered added a commit that referenced this pull request Sep 23, 2024
@blondered
Feature/DQ and R-Precision (#155)
5635268 
- Added `r-precision` calculation to `Precision`
- Added DQ metrics: `SufficientReco`, `UnrepeatedReco`, `CoveredUsers`
- Updated authors and links in readme
- Updated model descriptions in readme
Closes #102 
Closes #123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feldlime feldlime feldlime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R-Precision variant of Precision metrics Completeness metric (ratio of provided recos at top k positions)
2 participants
@blondered @feldlime