Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label and path handling when bzlmod is enabled #1599

Merged

Conversation

brentleyjones
Copy link
Contributor

@brentleyjones brentleyjones commented Jan 18, 2023

Fixes #1598.

Tested:

  • Bazel 5.4
  • Bazel 6.0 with --noincompatible_unambiguous_label_stringification
  • Bazel 6.0 with --incompatible_unambiguous_label_stringification
  • Bazel 6.0 with --enable_bzlmod

Tested:

- Bazel 5.4
- Bazel 6.0 with `--noincompatible_unambiguous_label_stringification`
- Bazel 6.0 with `--noincompatible_unambiguous_label_stringification`
- Bazel 6.0 with `--enable_bzlmod`
@brentleyjones brentleyjones changed the title Fix bazel_labels.normalize when bzlmod is enabled Fix label and path handling when bzlmod is enabled Jan 18, 2023
@brentleyjones brentleyjones merged commit 2424199 into main Jan 18, 2023
@brentleyjones brentleyjones deleted the bj/fix-bazel_labels.normalize-when-bzlmod-is-enabled branch January 18, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing transitive dep with bzlmod
1 participant